danreeves / dt-exchange

39 stars 18 forks source link

Add support for filtering the shop contents #2

Closed errnoh closed 1 year ago

errnoh commented 1 year ago

Goal is to merge functionality from the userscript based shop filtering into this extension. Still need to figure out things like how to easily configure filter rules, allow sharing/copypasting rules, have toggleable options, etc.

errnoh commented 1 year ago

I feel like we could do a text field configuration option where people can copy/paste filter definition similar to the ones currently being used. That would allow easy sharing of filter lists (bad part: shifts game towards "meta builds" instead of personal preference) which seems to be a common request people have.

errnoh commented 1 year ago

@danreeves multiple questions as I'm rather certain most of this is rather unidiomatic :)

(In addition there are still some issues in the filtering logic itself and I need to add some persisting toggles for the filtering functionality)

errnoh commented 1 year ago

Almost there. Only need to get configuration to persist for rest of the options, maybe find a way to clean some parts a bit and redo some of the naming.

errnoh commented 1 year ago

Hmm, functionality is there, naming is a bit less confusing and all options persist. Removing WIP label.

errnoh commented 1 year ago

So, I guess the questions now are:

danreeves commented 1 year ago

@errnoh just fyi i merged the melks store update so there are some conflicts here now