search

danreeves / dt-exchange

39 stars 18 forks source link

Investigate removing 'Buffer' library dependency in favor of btoa/atob #23

Closed Chris-Bitler closed 1 year ago

Chris-Bitler commented 1 year ago

These functions should serve the same purpose as the buffer library - we currently use the buffer library to match how FatShark base64's the auth data into a storage object, but if btoa and atob also work for the same purpose, this could eliminate ~2000 lines that end up bundled into the background js script

danreeves commented 1 year ago

I'm up for finding a smaller alternative but we need to be careful because native btoa doesn't support unicode: https://developer.mozilla.org/en-US/docs/Web/API/btoa#unicode_strings

There are workarounds though

danreeves commented 1 year ago

We can do this now FS has also removed their use of it!