danreeves / dt-exchange

39 stars 18 forks source link

Move build to gh actions #30

Closed danreeves closed 1 year ago

Coconutcoo commented 1 year ago

Would it make more sense to just create a static/ or assets/ folder, and move the icons there, and then have them copied over during the build? Then you can just gitignore the whole extensions folder.

Thinking about when we look at adding weapon icons, it'd be nice to not have to put them into extensions directly, and conversely if we end up generating further files there, we don't need to gitignore each of them by themselves?

danreeves commented 1 year ago

The manifest and icon files need to be in the extension directory still, can't ignore them. And the manifest needs to reference the built files in order to load them/allow them to be loaded

danreeves commented 1 year ago

i think the number of generated files in the extension directory should be limited so i think it's fine gitignoring them individually for now rather than complicate the build process by copying files around

danreeves commented 1 year ago

PRs now include build artifacts if you want the latest extension build from one, e.g. https://github.com/danreeves/dt-exchange/actions/runs/3839130258

Coconutcoo commented 1 year ago

Oh gotcha - I thought the manifest was being generated too, for some reason I thought it was pulling info from elsewhere. Fully agree with you now :)