search

danreeves / dt-exchange

40 stars 17 forks source link

Look for baseItemLevel when filtering for minStats, avoids rounding e… #48

Closed Coconutcoo closed 1 year ago

Coconutcoo commented 1 year ago

…rror

Fixes #47

Coconutcoo commented 1 year ago

Obviously the sum of the modifiers is still wrong, but I think people generally want the filter to be accurate as-per the big number shown on the RHS, rather than the sum.

Maybe we should add rename this to minModifierRating and add minModifierSum? Not sure how helpful it'd be in practicality though, a 379, 380, and 381 aren't going to meaningfully differ in-game, and I can't see many people that care about getting a "perfect" 380 then complaining that actually it's a "better" or "worse" 380 if the stats add up to +-1