search

danreeves / picotags

[Deprecated] Adds page tagging functionality to Pico.
MIT License
4 stars 3 forks source link

Special chars in tag name #3

Closed bricebou closed 10 years ago

bricebou commented 10 years ago

Hi Dan,

Sorry for the noise :) I'm French and when I first try picotags, I was using special chars (é, è...) in my tags. But I was having 404 errors when trying to display the corresponding tag page. I have tried to use, instead of "é" for example, é or $eacute; but with the same result, these being interpreted by the browser. Then, I'm not using special chars...

But would it be possible to do something about that ?

Thanks and see you !

danreeves commented 10 years ago

Sounds like it's either URL encoding or unicode being converted to ascii. I'll try to take a look at it.

bricebou commented 10 years ago

I've tried to add

AddDefaultCharset UTF-8

to my .htaccess but it doesn't change anything.

bricebou commented 10 years ago

Hi Dan,

I think I've managed to fix this issue by simply adding an urldecode() to the $this->current_tag variable definition.

It seems to work fine; for example:

The pull request will follow.