danreeves / picotags

[Deprecated] Adds page tagging functionality to Pico.
MIT License
4 stars 3 forks source link

keywords is unnecessary and should be removed #7

Closed danreeves closed 10 years ago

danreeves commented 10 years ago

It it best to keep the plugin simple and this same result could be attained with

{{ page.tags | join(',') }}

since Pico uses Twig templating: http://twig.sensiolabs.org/doc/filters/join.html

bricebou commented 10 years ago

Hi Dan,

Thanks for the tip ; but it seems that {{ page.tags | join(',') }} isn't working.

But {{ meta.tags | join(',') }} works perfectly ; see http://momh.fr/tutos/Linux/lftp_non_interactive with this piece of code in my index.html

{% if meta.tags %}
    <meta name="keywords" content="{{ meta.tags | join(',') }}">
{% endif %}

Is it normal ? I'm waiting to update the README.

danreeves commented 10 years ago

Ah sorry, yes meta.tags is what I meant. Nice catch.

danreeves commented 10 years ago

Fixed in b569a0148ccb00e5e18a9e1f3530023b630d934b

bricebou commented 10 years ago

Great ! Thanks again Dan :)