danruto / python-ntlm

Automatically exported from code.google.com/p/python-ntlm
0 stars 0 forks source link

Missing support for set_http_debuglevel #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
- try to set_http_debuglevel(100) on HTTPNtlmAuthHandler like following:

  import urllib2
  from ntlm import HTTPNtlmAuthHandler

  passman = urllib2.HTTPPasswordMgrWithDefaultRealm()
  # set url, user and password with the right values
  auth_NTLM = HTTPNtlmAuthHandler.HTTPNtlmAuthHandler(passman)
  opener = urllib2.build_opener(auth_NTLM)
  # suppose opener.handlers[6] is instance of
  #  ntlm.HTTPNtlmAuthHandler.HTTPNtlmAuthHandler
  opener.handlers[6].set_http_debuglevel(100)

What is the expected output?
- You can watch the client-server communication

The set_http_debuglevel method in AbstractNtlmAuthHandler class is missing.
I implemented it so I can supply my sollution. I think, this can be really
useful when developing.

I'm new in code.google.com so I'm not sure, if this issue-action is the
right way to contact project owner. If it's not excuse me please.

Original issue reported on code.google.com by jakub.to...@gmail.com on 14 Oct 2009 at 12:00

GoogleCodeExporter commented 9 years ago
Jakob,

Thank you for subitting the bug report, the issue list is the way to go.

Can you supply the patch you created, so I can integrate it into the codebase?

Matthijs

Original comment by Matthijs.Mullender on 16 Oct 2009 at 7:24

GoogleCodeExporter commented 9 years ago

Original comment by Matthijs.Mullender on 16 Oct 2009 at 7:24

GoogleCodeExporter commented 9 years ago
Sollution sent (hope to the right recipient).

I see "attach file" on this screen just now, so I attach the sollution right 
here
(and I'm sorry for bothering through email)

changed file: HTTPNtlmAuthHandler.py
changes are commented with the keyword "set_http_debuglevel"

Jakub

Original comment by jakub.to...@gmail.com on 16 Oct 2009 at 11:07

Attachments:

GoogleCodeExporter commented 9 years ago
Your patch was received and will be added to the repository.
I removed the specific author information from the file itself (because I do 
not want
to list all contributors in the source code), but will make sure to credit you 
in the
commit message. I hope this is acceptable.

Matthijs

Original comment by Matthijs.Mullender on 16 Oct 2009 at 11:14

GoogleCodeExporter commented 9 years ago
Closed in r77

Original comment by Matthijs.Mullender on 16 Oct 2009 at 11:15