search

dansalvato / melee-gci-compiler

Melee GCI Compiler is an application and scripting language that makes it easy for Super Smash Bros. Melee mod developers to inject custom code and data into Melee save files.
Mozilla Public License 2.0
35 stars 9 forks source link

"win32" -> "windows" in ppctools.py #3

Closed jmlee337 closed 3 years ago

jmlee337 commented 3 years ago

this allows ASM compilation to succeed on Windows (at least on my machine, otherwise I see Error compiling ASM: "'Windows' os is not supported")

dansalvato commented 3 years ago

Thank you, that must have been an oversight when I restructured the binary directories.

Looking at the file, my preference would be to remove this check entirely, and then increase the verbosity of the IOError right below it to include the full file path instead of just name. This first check is both redundant and misleading in comparison, because no OS is "unsupported" as long as the user can supply the required binaries.

jmlee337 commented 3 years ago

done