dansan / spring-replay-site

Website to upload, comment and download replays from/for the SpringRTS engine
http://replays.springrts.com/
GNU General Public License v3.0
11 stars 1 forks source link

delete replay when upload was successful #119

Open abma opened 4 years ago

abma commented 4 years ago

IMHO there is no need to keep replays local.

i'm not sure: should this be part of the upload or spads?

dansan commented 4 years ago

The idea was to allow downloading replays to watch them. The oldest x files are deleted to conserve disk space. Maybe it should be set to delete everything older than 1 week.

i'm not sure: should this be part of the upload or spads? I think it should be the responsibility of the replay site to keep/delete replay files. spads does not have public file serving capabilities.

abma commented 4 years ago

sorry, it was a bit confusing.

what i meant is: "replay_upload.py" should delete the replay after uploading it to replays.springrts.com.

so: where can replay_upload.py be found? i thought its in this repository?!

dansan commented 4 years ago

what i meant is: "replay_upload.py" should delete the replay after uploading it to replays.springrts.com. Oh… yes - that's make sense for autohosts. IMHO not so much for individuals. I propose to add a cmdline switch to enable source file deletion, keeping the previous behavior for backwards compatibility - to not surprise admin. so: where can replay_upload.py be found? i thought its in this repository?! It's in the srs directory (don't know why…): https://github.com/dansan/spring-replay-site/blob/master/srs/replay_upload.py