search

dansan / spring-replay-site

Website to upload, comment and download replays from/for the SpringRTS engine
http://replays.springrts.com/
GNU General Public License v3.0
11 stars 1 forks source link

srs_debug.log is spammed with Error deleting ... No such file or directory #121

Closed abma closed 4 years ago

abma commented 4 years ago

delete_old_replay_files.handle:43 Error deleting u'/var/www/servers/replays.springrts.com/spring-replay-site/srs/static/replays/20130101_001440_Tabula-v2__VJfu80_91.sdf.gz': [Errno 2] No such file or directory: '/var/www/servers/replays.springrts.com/spring-replay-site/srs/static/replays/20130101_001440_Tabula-v2__VJfu80_91.sdf.gz'

IMHO when it can't find the file it should update the db field:

https://github.com/dansan/spring-replay-site/blob/master/srs/management/commands/delete_old_replay_files.py#L44

-> remove the "else:" and make it always update the db

abma commented 4 years ago

as enhancement: search for orphaned files/replays :-)

dansan commented 4 years ago

Fixed in 32dfe3e5f7488d36edaa925a8c177dae9ce18b02