search

dansan / spring-replay-site

Website to upload, comment and download replays from/for the SpringRTS engine
http://replays.springrts.com/
GNU General Public License v3.0
11 stars 1 forks source link

Wrong win/lost attribution #89

Closed nrv closed 7 years ago

nrv commented 9 years ago

On that replay, the other team won the game :

http://replays.springrts.com/replay/707ac755e1650f5bc7356b1dea59fd27/

nrv commented 9 years ago

also on this one : http://replays.springrts.com/replay/57a4c755d3a925e4b767b62f3d689955/

abma commented 9 years ago

TS compution shown is correct, so false attribution should be easy to find:

if it decreases, team has lost / increase = team has won.

backlink to forum thread: https://springrts.com/phpbb/viewtopic.php?p=572151

jamerlan commented 8 years ago

lol.. such an old bug... still present! example: http://replays.springrts.com/replay/8501365676f737dcc424e226e92033f7/ [teh]decay team lost - but replays website displays "won"

Jamanno commented 8 years ago

still a bug. http://replays.springrts.com/replay/369389562bc9bfde0987390007b035a9/ In my battle history it is marked as lost as well, but my team won that game. I could provide more wrong battle results if needed.

dansan commented 8 years ago

removed - wrong browser tab ^.^

dansan commented 8 years ago

damn - wrong issue

dansan commented 8 years ago

I checked the replays, and the problem is with the demofile (sdf). In the place where the winning allyteams are listed, there is just the one that is shown as winner. It's obvious it's wrong, but that's simply what's in the file… I have manually corrected the four linked replays and will write a script that will go through all replays and check consistency with SLDB data and a fix to maintain it in the future.

jamerlan commented 8 years ago

dansan, please report this "demo files bug" to engine devs if you didn't yet ;-)

dansan commented 7 years ago

Forum thread: https://springrts.com/phpbb/viewtopic.php?f=71&t=35698 Engine issues: https://springrts.com/mantis/view.php?id=5384 https://springrts.com/mantis/view.php?id=4939

dansan commented 7 years ago

Engine issue has been fixed for next release. A temporary workaround is using SLDB TrueSkill data to guess the matches result.