search

danschultzer / premailex

Preflight for your HTML emails - inline styling and plain text.
MIT License
172 stars 20 forks source link

Fix spec on Premailex.HTMLInlineStyles.process/3 #58

Closed dmarkow closed 4 years ago

dmarkow commented 4 years ago

The recent updates to Premailex.HTMLInlineStyles.process/3 changed the spec, but the spec doesn't match the actual allowed arguments. Specifically, process/1 and process/2 default to nil for the 2nd/3rd arguments, but the spec doesn't allow nil there. This is causing "no local return" dialyzer warnings to bubble up into any app calling this function.

I updated the spec to allow nil for those arguments.

danschultzer commented 4 years ago

Thanks!

nickdichev commented 3 years ago

@danschultzer Do you have plans to cut a release with this fix sometime soon? Thanks!

danschultzer commented 3 years ago

Sorry for delay, on paternity leave, released v0.3.13 just now 😄

nickdichev commented 3 years ago

Thanks, and congrats!