search

danschultzer / premailex

Preflight for your HTML emails - inline styling and plain text.
MIT License
172 stars 20 forks source link

Styles are not inlined for the <html> tag #64

Closed SweetMNM closed 2 years ago

SweetMNM commented 3 years ago 
html {
  color: red;
}

This will not get injected to the html tag.

Possible Solution

https://github.com/danschultzer/premailex/blob/1c7fcd3282c43d442bbf74e910dc6615a63278f0/lib/premailex/html_inline_styles.ex#L59-L63 Those lines are causing the problem. I tested it by commenting the lines and the html styles get injected. I am curious why this was added in the first place.

Temporary Solution

If this issue affects you, Replace

{:premailex, "~> 0.3.0"}

With

{:premailex, git: "https://github.com/SweetMNM/premailex.git", tag: "v0.3.14"}

in your mix.exs

I can create a PR with my fork that removes those lines if there is no other reason to keep them. What do you think?