dansiegel / Mobile.BuildTools

The Mobile.BuildTools makes it easier to develop code bases in a clean, consistent, secure, and configurable way. Determine at Build which environment your app needs to run on, and what Client Secrets it should have. Plus many more amazing features!
http://mobilebuildtools.com
MIT License
228 stars 29 forks source link

Android : Sync Doc and code #89

Closed omatrot closed 4 years ago

omatrot commented 4 years ago

Description

Either the documentation or the task configuration is wrong:

    <TemplateManifestTask ConfigurationPath="$(BuildToolsConfigFilePath)"
                          ProjectName="$(MSBuildProjectName)"
                          ProjectDirectory="$(MSBuildProjectDirectory)"
                          SolutionDirectory="$(SolutionDir)"
                          IntermediateOutputPath="$(IntermediateOutputPath)"
                          TargetFrameworkIdentifier="$(TargetFrameworkIdentifier)"
                          ReferenceAssemblyPaths="$(_XATargetFrameworkDirectories)"
                          ManifestPath="$(TemplateAppManifest)"
                          Condition="$(BuildToolsEnableTemplateManifests)" />

The Task is passed an environment variable named TemplateAppManifest while the wiki says it is called TemplateManifestPath

Reproduction Steps

N/A

Expected Behavior

The Wiki in sync with the code.

Actual Behavior

N/A

Environment

Reproduction App

N/A

dansiegel commented 4 years ago

This is not actually a sync problem as much as the feature you're referencing works completely different between 1.x & 2.x. The wiki docs are accurate for 1.x., where as 2.x actually is meant to do in-place templating.