dansiegel / Prism.Plugin.Popups

This provides extensibility for Prism.Forms INavigationService to handle Popup Views
http://popups.prismplugins.com
MIT License
191 stars 39 forks source link

[Bug] Using Prism.Plugin.Popup in combination with IConfirmNavigationAsync breaks GoBack navigations #233

Open boufran1 opened 3 years ago

boufran1 commented 3 years ago

Description

Hi Dan, I am using the Prism bug template to submit this bug. I took some time to debug the issue on my own. It appears that when a Dialog is show to confirm whether the user wants to navigate back or not, the go back navigation fails when the value is positive. The dialog closes but the override in DoPop in PopupPageNavigationService returns a null page instead of the current page. This leads goback to fail with the default GoBackException in Prism which asks about modal or not.

I made a sample app to reproduce the issue. It

Steps to Reproduce

  1. Load the app in android.
  2. Navigate to ViewA using the displayed button.
  3. Hit the goback button or the hardware goback button.
  4. Confirm that you want to navigate back.
  5. Observe that the backward navigation never occured.

Expected Behavior

Navigate back to the MainPage

Actual Behavior

Stays in the current page

Basic Information

Screenshots

Reproduction Link

TestBug.zip

maxchu92 commented 3 years ago

@boufran1 try this https://popups.prismplugins.com/navigation/backbutton/