search

danslo / ApiImport

Boilerplate between the Magento API and ImportExport, so that you can do fast Array/XMLRPC/SOAP based product imports.
244 stars 79 forks source link

create singleton only when module is enabled #25

Closed bragento closed 10 years ago

bragento commented 10 years ago

Magento has a bug, where an exception is thrown, when you try to load a non existant singleton for the 2nd time.

The first time, the registry key is created with the value false.

The 2nd time, it will try to create the key again (because the condition is only if (!self::registry($registryKey)), but should be checking if the key is set) and raise an Exception.

danslo commented 10 years ago

Should be merged. Thanks for this!

bragento commented 10 years ago

thanks! could you tag a new release please?

We may not checkout the master branch on Production Systems ;)

danslo commented 10 years ago

Good point, 1.1.1 tagged!

davidverholen commented 10 years ago

thanks :)