danswer-ai / danswer

Gen-AI Chat for Teams - Think ChatGPT if it had access to your team's unique knowledge.
https://docs.danswer.dev/
Other
9.73k stars 1.08k forks source link

Slack connector: improve "workspace" description to avoid broken links #1709

Open danielnaber opened 4 days ago

danielnaber commented 4 days ago

Adding a Slack connector asks for a "Workspace" without a description what that looks like. I added xyz.enterprise.slack.com - indexing works, but the links in the result contain a duplicated "slack.com", like https://xyz.enterprise.slack.com.slack.com/archives/ABCDEF/p12345?thread_ts=12345.12345. The URL is built by get_message_link() in slack/utils.py I think.

I haven't tested leaving out the .slack.com but if that's the correct way to specify a workspace, there should be a hint in the connector UI in that direction, or the code should remove .slack.com automatically.

danielnaber commented 20 hours ago

I haven't tested leaving out the .slack.com but if that's the correct way to specify a workspace

I can confirm now that the "workspace" setting mustn't contain .slack.com for the search result links to work.