danswer-ai / danswer

Gen-AI Chat for Teams - Think ChatGPT if it had access to your team's unique knowledge.
https://docs.danswer.dev/
Other
9.77k stars 1.09k forks source link

Notion Connector - Block type `external_object_instance_page` is not supported via the API. #1761

Open colachg opened 2 days ago

colachg commented 2 days ago

This is related to issue #1053 (fixed in #1059) and #1230 (fixed in #1231).

CleanShot 2024-07-03 at 09 48 54@2x

The connector consistently fails after indexing 7,552 documents, which is extremely frustrating.

CleanShot 2024-07-03 at 09 51 17@2x

I'm not sure, this is a good way to fix.

                if result_type == "external_object_instance_page":
                    logger.warning(f"Skipping 'external_object_instance_page' ('{result_block_id}') for page '{page_block_id}': "
                                   f"Notion API does not currently support reading external blocks (as of 24/07/03) "
                                   f"(discussion: https://github.com/danswer-ai/danswer/issues/1761)")
                    continue

I believe people may encounter various types of block errors. Is there a universal method to catch all these errors? Currently investigating.