search

danth / pathfinder.vim

Vim plugin to suggest better movements
MIT License
290 stars 4 forks source link

fix neovim for v1.01 #16

Closed sandersantema closed 4 years ago

sandersantema commented 4 years ago

This should fix it again, the result of the else part of the code I changed is the same as the if part this however seems to be needed as nvim gives an error for vim.Function even though it shouldn't be triggered given that nvim returns 0 for :echo has('popupwin').

On another note, I think the latest change is quite a bit of a regression if not coupled with the ability to configure whether you want pathfinder to run all the time and with the :PathfinderBegin and :PathfinderRuncommands. I find it hard to figure out which motion I've actually done and which keys I could've better used. Usability was a lot better when you could manually run :PathfinderBegin and :PathfinderRun after which you returned to the previous location and could directly execute the most efficient keys as practice. Furthermore I really wouldn't want to run this plugin all the time when I don't have the attention for it all the time.

danth commented 4 years ago

@sandersantema It shouldn't be too difficult to add the commands back, I'll see what I can do.

Perhaps we could also consider highlighting the start and end cursor positions when the suggestion appears, to make it easier to know which motion it is about.