danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
1.11k stars 139 forks source link

fix(wezterm): Flip active and inactive tab colors #246

Closed jalil-salame closed 7 months ago

jalil-salame commented 8 months ago

This makes it easier to tell which tab is the active tab.

See the following image for an example:

stylix-wezterm-patch

The version of Wezterm running inside the virtual machine (with the yellow border) uses the current stylix styling, and the version outside the virtual machine uses my custom styling.

Current styling makes the inactive tabs have the same color as the terminal background, the proposed style flips this around.

I know this goes against the style guide, but I do believe it looks better this way.

(I am using the gruvbox colorscheme in case that matters)

trueNAHO commented 8 months ago

I know this goes against the style guide, but I do believe it looks better this way.

Both variants look good to me. As long as no one complaints or opens a PR to flip the colors again, we can simply merge this, if you like.

However, in the future the Stylix style guide should be more specific to avoid inconsistencies accross applications.

danth commented 7 months ago

What if we made inactive tabs the same color as the empty section at the right of the bar, and use the lighter color only for the active tab?

302032526-c3a1b430-79d5-42b5-bef5-f9aeb19c379f

(Created using bucket fill in GIMP, so this may or may not be actually possible)

jalil-salame commented 7 months ago

What if we made inactive tabs the same color as the empty section at the right of the bar, and use the lighter color only for the active tab?

302032526-c3a1b430-79d5-42b5-bef5-f9aeb19c379f

(Created using bucket fill in GIMP, so this may or may not be actually possible)

I prefer the way I did it, but this is better than the current state.

It should be possible.