search

danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
912 stars 107 forks source link

Feature Request: Base24 support #252

Open LovingMelody opened 5 months ago

LovingMelody commented 5 months ago

The underlying base16 library now supports the tinted-theming spec aka base24. Would be nice to see this included to add more colors to themes. With base24 being compatible with base16 this could be done in slow stages.

KiaraGrouwstra commented 4 months ago

when this lands here, the base24 github org offers implementations for a couple of applications we might use here then

Lord-Valen commented 3 weeks ago

Since https://github.com/tinted-theming/base24/blob/master/styling.md#base24-fallbacks is a thing, and base16-nix always generates a base24 compatible value according to that fallback rule, we should be able to just start doing this. In other words: It appears as though we already have the base24 schemes, we just aren't using them.

danth commented 3 weeks ago

Yep, I don't see any reason not to start implementing this on a module-by-module basis.

trueNAHO commented 3 weeks ago

It appears as though we already have the base24 schemes, we just aren't using them.

Yep, I don't see any reason not to start implementing this on a module-by-module basis.

Agreed. Until VIM highlight groups are implemented, supporting base24 schemes seems reasonable:

The solution I'm considering mimics vim's highlight groups

VIM's highlight groups might be the most scalable and practical solution I know of.

It would resolve nearly all our open issues regarding color scheme scalability. Additionally, our documentation could simply link to VIM's highlight groups documentation.

-- https://github.com/danth/stylix/issues/249#issuecomment-2012933635

Note that implementing VIM highlight groups is a non-trivial task. Supporting base24 yields faster and easier results.