search

danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
911 stars 107 forks source link

gnome.gnome-shell fails to build on nixos-unstable with stylix (shell_remove_dark_mode.patch patch fail) #261

Closed pcboy closed 4 months ago

pcboy commented 4 months ago

gnome.gnome-shell from nixpkgs#e97b3e4186bcadf0ef1b6be22b8558eab1cdeb5d fails to build in my flake because of this patch from stylix:

https://github.com/danth/stylix/blob/50cae37cfe23e5ad202ed53f48529139dfa0d008/modules/gnome/nixos.nix#L38

logs:

@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/gnbi7xbp99fns8my402yw4a6743wc6fb-gnome-shell-45.4.tar.xz
source root is gnome-shell-45.4
setting SOURCE_DATE_EPOCH to timestamp 1707677725 of file gnome-shell-45.4/data/theme/gnome-shell-light.css
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
applying patch /nix/store/fk581xnymypv70yki3p4cv46fzpdgl6n-fix-paths.patch
patching file data/org.gnome.Shell-disable-extensions.service
patching file js/ui/extensionDownloader.js
Hunk #1 succeeded at 116 (offset 6 lines).
Hunk #2 succeeded at 138 (offset 6 lines).
patching file js/ui/status/keyboard.js
Hunk #1 succeeded at 1103 (offset 11 lines).
patching file subprojects/extensions-tool/src/command-install.c
patching file subprojects/extensions-tool/src/command-pack.c
applying patch /nix/store/lvcbvgyzbw7lmiv7alrncl9md3nvbidd-shew-gir-path.patch
patching file subprojects/shew/src/meson.build
applying patch /nix/store/ywlajd02glm62sjbs3mb4ld06lbgpbkj-wrap-services.patch
patching file js/dbusServices/dbus-service.in
patching file js/dbusServices/dbus-service.service.in
patching file js/dbusServices/meson.build
Hunk #2 succeeded at 14 (offset -5 lines).
applying patch /nix/store/s6xymj47ad4dchcjfd0zywrgzyaq9rg1-greeter-logo-size.patch
patching file js/gdm/loginDialog.js
applying patch /nix/store/xjfym9hzz5yxhszcivryb9ykcg0lvvfn-0001-gdm-Work-around-failing-fingerprint-auth.patch
patching file js/gdm/util.js
Hunk #1 succeeded at 118 (offset -39 lines).
Hunk #2 succeeded at 530 (offset -14 lines).
Hunk #3 succeeded at 624 (offset -5 lines).
Hunk #4 succeeded at 690 (offset -5 lines).
applying patch /nix/store/s5m73iccwg6cyjb53f63rik456dj09ra-shell_remove_dark_mode.patch
patching file js/ui/panel.js
Hunk #1 FAILED at 361.
Hunk #2 FAILED at 374.
Hunk #3 FAILED at 397.
3 out of 3 hunks FAILED -- saving rejects to file js/ui/panel.js.rej

This is gnome 45.4

pcboy commented 4 months ago

I just found out I was pointing to an old version of stylix (danth/stylix/beb35709c9a769a5f279d3177af778a15dcbda46) instead of latest master. :facepalm:

It seems to be working with latest master!

danth commented 4 months ago

Maybe we should add a check on the version number to make this more user friendly