search

danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
1.11k stars 139 forks source link

Change specification for selection background #277

Closed danth closed 6 months ago

danth commented 6 months ago

Current specification

According to the current version of the style guide, base03 should be used as the background color for selected items. It is not specified what to use as the foreground color.

In Sakura - a light theme, using base05 as the foreground causes bad contrast.

Screenshot of Sakura with bad contrast

If we change the foreground to base00, this is improved.

Screenshot of Sakura with good contrast

However, base00 as the foreground causes bad contrast with Catppuccin Frappe - a dark theme.

Screenshot of Catppuccin Frappe with bad contrast

This is improved if we use the original setting of base05.

Screenshot of Catppuccin Frappe with good contrast

Suggested specification

I suggest changing the background to base02. This looks correct under both schemes, and is listed in the original base16 specification.

Screenshot of Sakura with new background

Screenshot of Catppuccin Frappe with new background

This may require some changes to existing modules which are following the old specification.

rice-cracker-dev commented 5 months ago

maybe give an option for user to use a base16 color instead of a predefined one?