search

danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
906 stars 105 forks source link

alacritty: ineligible text inside comments #341

Closed xokdvium closed 2 months ago

xokdvium commented 2 months ago

I'm using catppuccin-macchiato.yaml theme. The terminal is alacritty. I've noticed that some text in the console is too dark. This occurs for commented text and some other tools like hx --health (in the lsp column paths to /nix/store are unreadable):

image

Inline comments also are indistinguishable from background (the actual command is echo "hello" # asdfasdfasdf)

image

trueNAHO commented 2 months ago

Related: https://github.com/danth/stylix/issues/249

danth commented 2 months ago

How does this look without the transparent background?

xokdvium commented 2 months ago

Removing transparency does not seem to make a huge difference. The text still has very poor contrast with a dark background. Seems like this is a problem with alacritty specifically. With wezterm colors seem much more reasonable.

Alacritty: image

Wezterm: image

I think the issue is with the upstream base16-alacritty template:

Generated alacritty theme has really badly misconfigured highlight colors:

[colors.bright]
black = '0x494d64'
red = '0xf5a97f'
green = '0x1e2030'
yellow = '0x363a4f'
blue = '0x5b6078'
magenta = '0xf4dbd6'
cyan = '0xf0c6c6'
white = '0xb7bdf8'

The supposedly green color is actually 0x1e2030, which is dark blue... base16-alacritty repo seems quite a bit borked and does not conform to base16/stylix guidelines.

danth commented 2 months ago

Yes, that does look like an unusual arrangement of colors.

I would be happy to accept a modified version of the template, or an entirely new custom version to fix this issue.