alacritty: replace base16-alacritty with a custom theme

danth / stylix

System-wide colorscheming and typography for NixOS

https://stylix.danth.me/

MIT License

906 stars 105 forks source link

alacritty: replace base16-alacritty with a custom theme #346

Closed xokdvium closed 2 months ago

xokdvium commented 2 months ago

Removes mustache template with a theme specified with hm options. This removes the need for separate templates for TOML and YAML formats. The new style better aligns with other terminal modules (e.g. wezterm).

Implements support for base24 schemes with bright- mnemonics.

Closes #341.

danth commented 2 months ago

Would it not be better to implement the core logic first, and change the style in a follow-up PR? This would simplify future debugging, if someone is wondering why the colors have changed.

IMHO this is fine as one PR - removing the external template was only done to facilitate changing the colors. The final commit message should make this clear.

xokdvium commented 2 months ago

If it's fine by all of you, I'll leave commits unsquashed for review. Ping me when you think it's ready to be merged, or squash merge if it's not too much of a bother.

Here are the screenshots before and after:

Before:

After: