search

danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
904 stars 105 forks source link

zellij: `programs.zellij.*` no longer exists. #352

Closed Industrial closed 1 month ago

Industrial commented 2 months ago

Hi.

Zellij is now packaged in nixpkgs: https://github.com/NixOS/nixpkgs/blob/73e7e2108ab07de34aa9ea4d70242d9ff5fb7f04/pkgs/tools/misc/zellij/default.nix

I see it is configured as such: https://github.com/danth/stylix/blob/0fe277a3641a849478a94c7900c2d5a90609a306/modules/zellij/hm.nix#L8

  1. I'm not sure why that doesn't raise an error.
  2. It results in this: Screenshot_2024-04-25_22-42-50

Not really that nice :/

trueNAHO commented 2 months ago

Zellij is now packaged in nixpkgs: https://github.com/NixOS/nixpkgs/blob/73e7e2108ab07de34aa9ea4d70242d9ff5fb7f04/pkgs/tools/misc/zellij/default.nix

AFAIK, it has been since https://github.com/NixOS/nixpkgs/commit/f1df273a67a2b17f97bc833b76639cda3cdd5d9a.

I see it is configured as such:

https://github.com/danth/stylix/blob/0fe277a3641a849478a94c7900c2d5a90609a306/modules/zellij/hm.nix#L8

  1. I'm not sure why that doesn't raise an error.

Stylix currently locks Home Manager to the 820be197ccf3adaad9a8856ef255c13b6cc561a6 revision:

https://github.com/danth/stylix/blob/0fe277a3641a849478a94c7900c2d5a90609a306/flake.lock#L166-L185

This points to the valid programs.zellij attribute set:

https://github.com/nix-community/home-manager/blob/820be197ccf3adaad9a8856ef255c13b6cc561a6/modules/programs/zellij.nix#L14

Could you elaborate on the expected error?

  1. It results in this: Screenshot_2024-04-25_22-42-50

Not really that nice :/

Could you elaborate what specific elements are unpleasing?

afresquet commented 2 months ago

Can't reproduce this myself, zellij works fine for me

nixpkgs: 58a1abdbae3217ca6b702f03d3b35125d88a2994 home-manager: 2af7c78b7bb9cf18406a193eba13ef9f99388f49 stylix: 0fe277a3641a849478a94c7900c2d5a90609a306 zellij: 0.40.0

danth commented 2 months ago

I cannot find any evidence that the programs.zellij module was removed:

https://github.com/nix-community/home-manager/blob/master/modules/programs/zellij.nix

Stylix currently locks Home Manager to the 820be197ccf3adaad9a8856ef255c13b6cc561a6 revision

Note that this only applies for our tests, and users can still combine it with whichever Home Manager version they choose.

trueNAHO commented 1 month ago

To: @Industrial

Feel free to reopen this issue, if it is still a problem.

danth commented 1 month ago

Possibly related to #379