danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
904 stars 105 forks source link

tofi: init #355

Closed aftix closed 1 month ago

aftix commented 2 months ago

Added stylix target for tofi, a wayland dmenu alternative.

Based off the existing rofi target.

aftix commented 2 months ago

Locally, the failed CI tests are working for me. The tofi HM module is only two weeks old, could the stylix flake input for it be older than that?

trueNAHO commented 2 months ago

Locally, the failed CI tests are working for me.

All tests are failing for this reason:

Run nix -L build github:danth/stylix/5d6eadb3edcd8bcb64090fa27a1527eeeb87d738#packages.x86_64-darwin.docs
error:
       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:9:12:
            8|
            9|   strict = derivationStrict drvAttrs;
             |            ^
           10|

       … while evaluating derivation 'stylix-book'
         whose name attribute is located at /nix/store/fszphhr0kc59brk510m3a579vjbjdy2s-source/pkgs/stdenv/generic/make-derivation.nix:331:7

       … while evaluating attribute 'patchPhase' of derivation 'stylix-book'
         at /nix/store/ljy1ym11j0rrnc3s3if80darc5gi1msn-source/docs/default.nix:44:3:
           43|
           44|   patchPhase = ''
             |   ^
           45|     cp ${../README.md} src/README.md

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: The option `programs.tofi' does not exist. Definition values:
       - In `/nix/store/whm360hyl2wcjbj5kal4wxibpb1hnr5q-modules/tofi/hm.nix':
           {
             _type = "if";
             condition = true;
             content = {
               settings = {
           ...

The tofi HM module is only two weeks old, could the stylix flake input for it be older than that?

You can compare your minimum Home Manager revision requirement with the one in flake.lock:

https://github.com/danth/stylix/blob/2f29ecd3e4c0ebf75f46647b4c4fb7261b978aac/flake.lock#L166-L185

However, based on the error, it seems like the Home Manager input is too old. In that case, update the Home Manager input in this PR.

aftix commented 2 months ago

I've changed to withHashtagand removed an unnecessary string interpolation

aftix commented 1 month ago

It was being used as the background, i've updated from base00 -> base02

danth commented 1 month ago

Apologies, I meant selection (which is still base03), not background. base00 is correct as a general background color.

aftix commented 1 month ago

selection is the foreground, currently the selection background is set to the same as the default background (base00). The selection is base03

danth commented 1 month ago

In that case, I think it's fine. We don't really have an agreed color for selection foregrounds right now.