search

danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
904 stars 105 forks source link

gnome: default setting for `stylix.cursor` is not displayed correctly #359

Open danth opened 1 month ago

danth commented 1 month ago

As described in https://github.com/danth/stylix/pull/357#pullrequestreview-2046506635

henrispriet commented 1 month ago

In the comments on #357, this is said:

The only case where this could introduce new user facing issues is if the user is tracking our pinned nixpkgs, which is not something we currently recommend (since it's only bumped if necessary to make the tests pass).

What is meant exactly with "tracking our pinned nixpkgs"? I'd assume it means not making stylix follow the user's flake's nixpkgs input, but that is what's in the installation chapter of the book.

{
  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";
    stylix.url = "github:danth/stylix";
    # this would be "not tracking the pinned nipxkgs" (which i also tried, but didn't change anything)
    # stylix.inputs.nixpkgs.follows = "nixpkgs";
  };

  #...
}

Anyway, I ask this because I ran into this issue (the square cursor) on my new install. I've found a cursor package that works fine now, but the default as well as another cursor package I tried (bibata-cursors, the "Bibata Modern Classic" cursors) both have this bug.

Some relevant commits from my config repo: installed stylix, default cursor tried Bibata quitom-cursor-theme works

Am I doing something wrong in my config w.r.t. "tracking the pinned nixpkgs" or do these cursors simply not work with stylix on gnome right now?

danth commented 1 month ago

They just don't work any more, I'm not sure why. I haven't spent much time looking into the cause of this issue.

If we find a similar looking cursor theme, we could simply change the default to one which works.

By "tracking stylix's pinned nixpkgs", I meant doing the opposite to what you described - making the user's nixpkgs input follow that from Stylix.

henrispriet commented 1 month ago

By "tracking stylix's pinned nixpkgs", I meant doing the opposite to what you described - making the user's nixpkgs input follow that from Stylix.

I see. That makes sense.

If we find a similar looking cursor theme, we could simply change the default to one which works.

Maybe just the one used in the testbed? It would be nice regardless that the cursor works out of the box.

trueNAHO commented 1 month ago

Related: https://github.com/danth/stylix/issues/379#issuecomment-2125189417

danth commented 1 month ago

Maybe just https://github.com/danth/stylix/pull/357#issuecomment-2101366556? It would be nice regardless that the cursor works out of the box.

However, Adwaita is a GNOME-specific theme, which could look out of place in other environments. Our defaults should be fairly neutral.