search

danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
904 stars 105 forks source link

vesktop: init #365

Closed itsvic-dev closed 1 month ago

itsvic-dev commented 1 month ago

Adds a generated theme to Vesktop. (might need extra tweaks for the colors)

image

image

Closes #364

itsvic-dev commented 1 month ago

image

itsvic-dev commented 1 month ago

applied the suggestions and rebased to master 👍🏻

danth commented 1 month ago

There has previously been some discussion on whether we want to support modifications which may break the terms of service of Discord. However, it appears that this module only takes effect if the user has chosen to install Vesktop, in which case they should already be aware they're using a modified client.

In terms of the theme itself, the color for unread channels looks a bit unusual, but that may just be your particular config. Are you using a base16 scheme or one generated automatically by Stylix?

itsvic-dev commented 1 month ago

I'm using the color scheme generated by Stylix. I agree that it is a bit unusual, so some experimentation with the theme might be needed. But I think that this could be addressed in a separate PR.

danth commented 1 month ago

Yeah okay, that's an issue with the theme generator and not this module.

itsvic-dev commented 1 month ago

I believe so, yes.