search

danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
904 stars 105 forks source link

Draft: Adapt KDE testbed for Plasma 6 #386

Closed Kitt3120 closed 1 month ago

Kitt3120 commented 1 month ago

Include Plasma 6 and new attribute names.

I don't know exactly how the testbed system works, this is based on a guess. If I understood it correctly, it's enough to add these attributes and, if any of them match, the KDE module gets activated? :) Then everything should work.

Kitt3120 commented 1 month ago

Okay, I see, it's not how I thought it works.

Edit: Read the markdown doc about testbeds. I was completely wrong in my assumption on how testbeds work. Doesn't have anything to do with automatically enabling the module, it's just for testing.

Is it even possible to have a testbed for Plasma 5 and 6 at the same time here? Or should we rename the kde module to kde5 and make a separate kde6 module? This would allow for separate testbeds. Also, can 2 kde modules even coexist, or do they conflict each other?

Also, we wouldn't really have to worry about updating the kde5 module, as it probably won't have to change anymore in the future.

An alternative to this is to wait until all major distros release with Plasma 6, then update the kde module. Until then, Plasma 6 users would have to manually disable the GNOME/GTK sync service, as described here. I would suggest adding a note for this in the README and docs.

danth commented 1 month ago

can 2 kde modules even coexist, or do they conflict each other?

Detecting which KDE version is installed would be difficult, since this information isn't always available within Home Manager. So the modules could co-exist, but one of them may have to only be enabled manually to prevent conflicts.

However, it may be possible to support both in a single module, since an obsolete configuration file still being created should have no effect.

Kitt3120 commented 1 month ago

Okay. So should we adapt the kde module to also include kded6rc and update the testbed to use Plasma 6?

danth commented 3 weeks ago

Yes, that would be reasonable.