danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
904 stars 105 forks source link

waybar: put font-family string in quotes. #391

Closed Rick-T closed 1 month ago

Rick-T commented 1 month ago

Using 0xProto as font-family breaks waybars style.css (Error: Expected a string). This fixes it.

Rick-T commented 1 month ago

Note: I'm new to nix and stylix, so I'm not sure if this is the best solution, but it works.

There might be other places where stylix is generating css-files which might run into the same problem. I haven't checked. Maybe someone more knowledgeable about stylix has an idea how to fix similar problems more generally.

Rick-T commented 1 month ago

Using 0xProto as font-family breaks waybars style.css (Error: Expected a string). This fixes it.

What exactly is causing this error? Stylix (Nix) at build time or Waybar at run time?

It's Waybar at runtime. It crashes on startup, with the error hinting at style.css.

There might be other places where stylix is generating css-files which might run into the same problem. I haven't checked. Maybe someone more knowledgeable about stylix has an idea how to fix similar problems more generally.

If this is a Waybar run time issue, then it might be a CSS or Waybar problem. Unfortunately, I am not very familiar with either one.

If this is a general CSS problem, it would be greatly appreciated to apply this fix to all CSS files in the project.

It might be a Waybar problem as well. I'm also not too familiar with that one. I'm just trying to set up my system :laughing:

I'm not going to look into this in more detail because wrapping my head around Nix is already overwhelming enough for me at the moment.

I have removed the superfluous commits from my branch. You should be able to merge this now if you find the changes acceptable.