search

danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
904 stars 105 forks source link

stylix: simplify `mkEnableTarget` documentation #399

Closed trueNAHO closed 1 month ago

trueNAHO commented 1 month ago

Simplify the stylix.mkEnableTarget documentation to simplify its documentation extension in https://github.com/danth/stylix/pull/244.

Due to some targets not being enabled by default with stylix.mkEnableTarget, the documentation incorrectly generates Default: false in some cases with https://github.com/danth/stylix/pull/399. Resolving this involves manually extending docs/settings.nix or enabling all targets by default with stylix.mkEnableTarget.

-- https://github.com/danth/stylix/issues/400

trueNAHO commented 1 month ago

LGTM, but I don't see the need for this if #398 is merged

398 replaces lib.mkOption with lib.mkEnableOption, while this PR makes defaultText optional. Both PRs cause merge conflicts, but address different aspects.

danth commented 1 month ago

This needs to be rebased since #398 was merged