danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
1.23k stars 157 forks source link

lightdm: support colors in addition to wallpaper #431

Open arunoruto opened 5 months ago

arunoruto commented 5 months ago

I have had some issues with GDM and wanted to try out LightDM, but somehow the color scheme and wallpaper isn't applied. Am I missing something?

danth commented 5 months ago

The LightDM module should only set the backgruound image currently.

(It's one of the oldest modules in Stylix and hasn't been updated for a few years, apart from changes which affect all modules)

arunoruto commented 5 months ago

I am not sure if something has changed, but it isn't setting the wallpaper now. It defaults to the default gruvboxy Nixos image.

trueNAHO commented 5 months ago

The LightDM module should only set the backgruound image currently.

it isn't setting the wallpaper now. It defaults to the default gruvboxy Nixos image.

The background image should delegate to stylix.image:

https://github.com/danth/stylix/blob/a7fbda1fd965cc22e62463896a4af0342cb00e6a/modules/lightdm/nixos.nix#L7-L8

I am not sure if something has changed

The last notable change was https://github.com/danth/stylix/commit/7682713f6af1d32a33f8c4e3d3d141af5ad1761a, requiring the use of stylix.enable = true;.

For reference, here is the commit history for the LightDM module: https://github.com/danth/stylix/commits/master/modules/lightdm/nixos.nix.

arunoruto commented 5 months ago

Seems like I set a wallpaper as a default wallpaper at some point and that one got chosen. Sorry for the false heads up!

And I will be looking into how to theme lightdm using gtk or slick, since they are easier to configure!