danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
1.23k stars 157 forks source link

Stylix theme won't apply to vscode after update #510

Open Arut0ria opened 3 months ago

Arut0ria commented 3 months ago

You can get my nixos config there : https://github.com/Arut0ria/nixos-desktop-config

I can't understand why it broke. I can't see the extension un vscode anymore.

Arut0ria commented 3 months ago

I found something that sort of fixed it, I removed the extensions.json in ~/.vscode-oss/extensions/ and added this option to my vscode nix config :

{ pkgs, lib, config, ... }: {
  options = {
    vscode-program.enable = lib.mkEnableOption "Enables vscodium.";
  };

  config = lib.mkIf config.vscode-program.enable {
    programs.vscode = {
      enable = true;

      /*
        Here
      */
      mutableExtensionsDir = false;

      package = pkgs.vscodium;
      extensions = with pkgs.vscode-extensions; [
        jnoortheen.nix-ide
        bierner.emojisense
      ];
    };
  };
}
trueNAHO commented 3 months ago

You can get my nixos config there : https://github.com/Arut0ria/nixos-desktop-config

I am unable to find a flake.lock file. What is the pinned Stylix version?

I can't understand why it broke. I can't see the extension un vscode anymore.

Is it related to https://github.com/danth/stylix/issues/417?

Arut0ria commented 3 months ago

I don't think it is related to #417.

Vscode won't load the stylix extension, unless I add this option to my nixos configuration:

programs.vscode.mutableExtensionsDir = false;

I'll upload the flake.lock.

trueNAHO commented 3 months ago

I can't understand why it broke. I can't see the extension un vscode anymore.

What exactly do you mean by "anymore"? For reference, the vscode directory has been untouched for the last 2 months: https://github.com/danth/stylix/commits/master/modules/vscode.

I'll upload the flake.lock.

Seems to be up-to-date with 94d70292d0c687ebacb65d00bd516cbefa18d3ca.

Vscode won't load the stylix extension, unless I add this option to my nixos configuration:

programs.vscode.mutableExtensionsDir = false;

Maybe @dafitt or @danth are more familiar with the VS Code setup.

danth commented 6 days ago

Perhaps the mutable extensions directory allowed the extension to be disabled/deleted somehow?