danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
1.16k stars 143 forks source link

stylix: re-add `flake-utils` dependency #512

Closed trueNAHO closed 2 months ago

trueNAHO commented 2 months ago

To: @danth

Why was the flake-utils dependency removed in commit ff5da2914cfc ("Remove dependency on flake-utils :heavy_minus_sign:")?

Some of its functionality, like handling the --impure flag, are neat but would be too costly to re-implement on our side.

Re-adding flake-utils and injecting the "i686-linux" system would resolve this issue:

trueNAHO commented 2 months ago

I already have a working PR. Once it is cleaned up I can submit it for review (tomorrow).

Coincidentally, the PR publicly interfaces an overridable list of supported architectures.

danth commented 2 months ago

I didn't think it was worth the extra dependency for something which could be implemented fairly easily using functions from the nixpkgs library.

Admittedly things have changed in both Stylix and flake-utils since that commit; there may also be additions to the nixpkgs library which could be useful here.