danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
1.16k stars 143 forks source link

Infinite recursion encountered #561

Closed kay-mw closed 1 month ago

kay-mw commented 1 month ago

I recently updated my flake inputs and encountered an infinite recursion error when attempting to rebuild my system. After some troubleshooting, I found that removing the NixOS stylix module from my config fixed the error. My home manager stylix config seems to be fine.

I am not sure what is responsible, but I have tried the following troubleshooting steps:

None of these steps were successful. Below is my NixOS stylix config and the full trace.

/modules/nix/stylix/default.nix
``` { pkgs, ... }: { stylix = { enable = true; autoEnable = false; image = ./equivalent_exchange.jpeg; polarity = "dark"; imageScalingMode = "fit"; base16Scheme = "${pkgs.base16-schemes}/share/themes/kanagawa.yaml"; homeManagerIntegration.followSystem = true; fonts = { sizes = { applications = 9; terminal = 11; }; monospace = { package = pkgs.meslo-lgs-nf; name = "MesloLGS NF Regular"; }; }; cursor = { name = "Bibata-Modern-Classic"; package = pkgs.bibata-cursors; size = 20; }; targets = { chromium.enable = true; gnome.enable = true; gtk.enable = true; }; }; } ```

Trace: https://gist.github.com/kay-mw/acc5e6751abf18b6cc3eff5e1385bd4b

trueNAHO commented 1 month ago
    autoEnable = false;

Try setting autoEnable to its default value (true).

Maybe this is related to https://github.com/danth/stylix/pull/419.

kay-mw commented 1 month ago
    autoEnable = false;

Try setting autoEnable to its default value (true).

Maybe this is related to #419.

Just gave that a go, unfortunately I am still getting the same infinite recursion error.

heyimnova commented 1 month ago

I ran into that same infinite recursion error. I found that holding nixvim back on an older version prevents it. Are you using also nixvim and could it be conflicting here?

kay-mw commented 1 month ago

I ran into that same infinite recursion error. I found that holding nixvim back on an older version prevents it. Are you using also nixvim and could it be conflicting here?

Thank you! I do use nixvim, and indeed reverting to a previous commit fixed the infinite recursion issue. Specifically, it seems that this specific commit is where the error begins, which makes sense as it does mention infinite recursion as a potential problem across the commit description and code comments.

My nix proficiency is far too low to understand why this commit leads to an infinite recursion, specifically when you have a stylix NixOS configuration enabled (I tried forking nixvim to figure it out, but didn't really get anywhere). I'll close this issue for now as it seems like more of a nixvim issue and than a stylix issue, but I very well may be wrong so feel free to re-open it if that's the case!