search

danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
1.16k stars 143 forks source link

[BUG] SignColumn not transparent #599

Open anotherhadi opened 1 day ago

anotherhadi commented 1 day ago

The sign column is no longer transparent after update. Even with stylix.targets.nixvim.transparentBackground.signColumn = true

My full configuration can be found at https://github.com/anotherhadi/nixy, related files are /themes/stylix/nixy.nix and /home/programs/nvim

anotherhadi commented 1 day ago

Maybe related to #536

trueNAHO commented 9 hours ago

The sign column is no longer transparent after update. Even with stylix.targets.nixvim.transparentBackground.signColumn = true

[...]

Maybe related to #536

The default colorscheme plugin changed from base16-nvim to mini.base16:

Add the stylix.targets.nixvim.plugin option to select between the
previous base16-nvim and the new default mini.base16 [...] plugin,
offering better plugin integration.

-- https://github.com/danth/stylix/commit/17f6d6e5aaf3c9eb393a07aeb34d374d7130081e

I am pretty sure that the sign column not being transparent is an intentional feature of mini.base16.

Consider adding a new stylix.targets.nixvim.plugin variant, patching base16-nvim or mini.base16 upstream, or waiting for Stylix to implement the Vim highlight groups:

Considering that the roadmap eventually causes Stylix to implement all templates without relying on external dependencies, it might be easiest to lock the current dependency versions to avoid wasted maintenance effort.

-- https://github.com/danth/stylix/issues/567#issuecomment-2403246345

anotherhadi commented 3 hours ago

Even with stylix.targets.nixvim.plugin = "base16-nvim"; I still have the same issue. Shouldn't this revert any changes made upstream?