search

danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
1.23k stars 158 forks source link

[BUG] SignColumn not transparent #599

Open anotherhadi opened 1 month ago

anotherhadi commented 1 month ago

The sign column is no longer transparent after update. Even with stylix.targets.nixvim.transparentBackground.signColumn = true

My full configuration can be found at https://github.com/anotherhadi/nixy, related files are /themes/stylix/nixy.nix and /home/programs/nvim

anotherhadi commented 1 month ago

Maybe related to #536

trueNAHO commented 1 month ago

The sign column is no longer transparent after update. Even with stylix.targets.nixvim.transparentBackground.signColumn = true

[...]

Maybe related to #536

The default colorscheme plugin changed from base16-nvim to mini.base16:

Add the stylix.targets.nixvim.plugin option to select between the
previous base16-nvim and the new default mini.base16 [...] plugin,
offering better plugin integration.

-- https://github.com/danth/stylix/commit/17f6d6e5aaf3c9eb393a07aeb34d374d7130081e

I am pretty sure that the sign column not being transparent is an intentional feature of mini.base16.

Consider adding a new stylix.targets.nixvim.plugin variant, patching base16-nvim or mini.base16 upstream, or waiting for Stylix to implement the Vim highlight groups:

Considering that the roadmap eventually causes Stylix to implement all templates without relying on external dependencies, it might be easiest to lock the current dependency versions to avoid wasted maintenance effort.

-- https://github.com/danth/stylix/issues/567#issuecomment-2403246345

anotherhadi commented 1 month ago

Even with stylix.targets.nixvim.plugin = "base16-nvim"; I still have the same issue. Shouldn't this revert any changes made upstream?

trueNAHO commented 1 month ago

Cc: @soulsoiledit

soulsoiledit commented 1 month ago

For the mini.base16 issue, it can be fixed by adding highlightOverride to each option. It seems like it's working with base16-nvim to me. The LineNr (number column) is not transparent however, which is a bit jarring though and might be what you're referring to? I don't think this was properly supported in the past either. Perhaps LineNr should be set as well?

anotherhadi commented 1 month ago

For the mini.base16 issue, it can be fixed by adding highlightOverride to each option. It seems like it's working with base16-nvim to me. The LineNr (number column) is not transparent however, which is a bit jarring though and might be what you're referring to? I don't think this was properly supported in the past either. Perhaps LineNr should be set as well?

In my setup, neither the LineNr column nor the Sign column are transparent. How do you define highlightOverride to each option?

soulsoiledit commented 1 month ago

To clarify, highlightOverride would be used upstream. You can take a look here to see how to do it locally.

Also check if relativenumber or cursorline are enabled. They change the highlight groups used for the number column and sign column respectively.