danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
1.21k stars 158 forks source link

hyprlock: new module prevents specifying any other attributes #629

Open kjkent opened 2 days ago

kjkent commented 2 days ago

With the recent addition of https://github.com/danth/stylix/pull/619 (whoo new module btw, thanks @oscar-schwarz :partying_face: ) , I've noticed that any attributes applied to the input-field setting cause a conflict with the Stylix module, e.g:

input-field = [
            {
              size = "200, 50";
              position = "0, -80";
              monitor = "";
              dots_center = true;
              fade_on_empty = false;
              outline_thickness = 5;
              placeholder_text = "Password...";
              shadow_passes = 2;
            }
          ];

I notice that in the HM module's example and in my config, the setting is given as a list, whereas the new Stylix module provides an attrset.

Or, are the examples to mean that multiple input fields can be defined, as I also have this in my config:

image = [
            {
              path = "${avatar}";
              size = 150;
              border_size = 4;
              border_color = "rgb(0C96F9)";
              rounding = -1; # Negative means circle
              position = "0, 200";
              halign = "center";
              valign = "center";
            }
          ];

which I assume means multiple images can be defined and positioned

Perhaps there's some merging strategy that can be used to set the color opts whether they're a list or attribute set?

Edit: I just tested, and changing my input-field from a single-item list to an attrSet has fixed things and the configs have merged without me needing to omit input-field from my config entirely. As the examples on Home Manager have it as a list.... should I close this or leave it open?

trueNAHO commented 1 day ago

I just tested, and changing my input-field from a single-item list to an attrSet has fixed things and the configs have merged without me needing to omit input-field from my config entirely. As the examples on Home Manager have it as a list.... should I close this or leave it open?

If the list functionality has a purpose, we should resolve this. Otherwise, we should submit a Home Manager PR updating the example, and once merged close this issue.