danth / stylix

System-wide colorscheming and typography for NixOS
https://stylix.danth.me/
MIT License
1.16k stars 143 forks source link

Evaluation fails with home-manager 22.11, and cannot disable mako target #70

Closed mrcjkb closed 1 year ago

mrcjkb commented 1 year ago

Hi.

Since #65, I am unable to evaluate my NixOS configuration, as I am still on home-manager 22.11.

I tried disabling the mako target with both

home-manager.sharedModules = [{
    stylix.targets.mako.enable = false;
}];

and

home-manager.users.mrcjk = {
    stylix.targets.mako.enable = false;
};

as described here, but to no avail. I always end up with

building the system configuration...
error: The option `home-manager.users.mrcjk.services.mako' does not exist. Definition values:
       - In `/nix/store/l84b6hgjc6i9nsgg6mbxdgdf3ddc2pxv-modules/mako/hm.nix':
           {
             _type = "if";
             condition = false;
             content = {
               backgroundColor = "#212121";
           ..
dwarfmaster commented 1 year ago

I think the best thing to do would be to create a release-22.11 branch that tracks NixOS/home-manager 22.11, while master tracks the main branch of those project.

danth commented 1 year ago

I agree, there needs to be some support for the latest stable release, without holding back changes which require unstable.

I've created release-22.11 with the Mako commit reverted.

mrcjkb commented 1 year ago

Thanks!