danthareja / node-google-apps-script

[DEPRECATED - use clasp instead] The easiest way to develop Google Apps Script projects
MIT License
353 stars 70 forks source link

large refactor, various improvements #15

Closed shrugs closed 8 years ago

shrugs commented 9 years ago

I'm at intern at Google this summer; thanks for your work on node-google-apps-script. I used it a bunch but ran into some small issues so I forked it and added some fixes and features.

Sorry for the large PR on a Friday :)

danthareja commented 9 years ago

This is awesome @Shrugs!! I've seen you around the issues helping out a lot. Thank you very much for your contributions with other issues and helping me stay on top of this project and keep it alive.

I'll give it a good look over the weekend and get back to you soon.

danthareja commented 9 years ago

Sorry for the delay on this, @Shrugs. Thanks again for your work on this and for taking the time to submit a PR. Before merging this I want to get some insight into the workflow you had with this tool. It seems to differ quite a bit from my own initial thoughts. I like a lot of your changes and I'm totally open to merging them but first want to understand your process more and see if we can make this tool work for both workflows.

I'm most curious in the removal of gaps download and best practice of never editing in the web IDE. I agree that having the local copy as master makes a lot of sense, but how are you testing as you develop?

As I understand, there's no way to run an app script locally. When I was developing with this tool (I'll admit I am still new to many features in the Apps Script API), I found myself Logger.loging all over the place. I would have felt it as a burden to push every time I wanted to run my code. At the time, my thought was to keep master in the web IDE to speed up development/testing and then gaps download right before a version control commit.

Did you handle testing differently?

shrugs commented 9 years ago

Yeah, the logging situation needs to be improved. Unfortunately the Apps Script API doesn't expose logs at the moment, but if they ever integrate with Cloud Logging, that could be added to gaps.

My development workflow looks like this:

I end up logging a lot as well and just keep the web IDE open for when I need to see them, which involves a bit of tabbing between the open document, sublime, and the web IDE. I'd agree that it's a bit more cumbersome to now have another window to switch between, but working in a real editor makes that entirely worth it for me.

I wouldn't mind adding the download functionality back, but what do you think the best implementation is?

I couldn't think of an ideal situation for the download functionality, so I just removed it.

@danthareja

Thanks for taking the time to check it out :)

danthareja commented 8 years ago

Hey @Shrugs, finally pulled this in! It was too long of a time coming, but thanks again for your solid work. The auth flow changed a little from the UI, so I just changed that around. Also, I ended up going with gapps, I think it makes more sense from a Google Apps perspective. I thought a bit more about downloading and kind of agree that it doesn't make anymore sense. If people complain maybe we can add it back.

I added your name under an Acknowledgements section. Right now it links to your github profile, if you want it to go somewhere else let me know!

shrugs commented 8 years ago

Cheers, thanks for the work on node-google-apps-script!