search

danthedeckie / simpleeval

Simple Safe Sandboxed Extensible Expression Evaluator for Python
Other
451 stars 85 forks source link

Add python3.8 support #64

Closed zhudotexe closed 4 years ago

zhudotexe commented 5 years ago

Fixes #61.

Python 3.8 now uses ast.Constant instead of ast.Num, ast.Str, ast.Bytes, ast.Ellipsis, and ast.NameConstant - this PR adds a node handler for it.

pep8speaks commented 5 years ago

Hello @mommothazaz123! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 359:80: E501 line too long (82 > 79 characters) Line 361:80: E501 line too long (103 > 79 characters)

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-1.2%) to 98.451% when pulling 65ab6c510563a490f22b7307b7370457cd839afe on mommothazaz123:py38 into b47858d7153a05f64da16c4425c38f481e510d12 on danthedeckie:master.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-1.2%) to 98.451% when pulling 65ab6c510563a490f22b7307b7370457cd839afe on mommothazaz123:py38 into b47858d7153a05f64da16c4425c38f481e510d12 on danthedeckie:master.

pokoli commented 5 years ago

I've run on the same issue and I can confirm that this PR fixes the issue.

pokoli commented 4 years ago

@danthedeckie Could you upload a new version with this fix to pypi?

This is a blocking Tryton to be used on Python3.8.