Dockerfile

[daniel-lang]

Hey Daniel,

I saw that this project has a docker image on Docker Hub, but no documentation or Dockerfile exists. To make it possible to update the container to Python 3 and for others to build their custom version I added a Dockerfile which should be similar to the original one. It is based on Alpine and uses the latest stable version of Python which is currently Python 3.8

[coveralls]

Coverage remained the same at 75.997% when pulling 0548046abad3b3228bb2b458f27a89ec50a5bdce on daniel-lang:dockerfile into 883a1888ba6f6c657b3b5dc88131b147534ba399 on danthedeckie:master.

[codecov-io]

Codecov Report

Merging #11 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   74.96%   74.96%           
=======================================
  Files          36       36           
  Lines        2920     2920           
  Branches      230      230           
=======================================
  Hits         2189     2189           
  Misses        691      691           
  Partials       40       40           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 883a188...0548046. Read the comment docs.

[mattaw]

Great work, just booted a container using your file. I think a few tweaks are needed for production use, one being that the database needs to be in a subdirectory so I can create a named volume for it. My docker run command is:

docker run -it -p 9003:5000 -v streetsign:/usr/src/app/database maswabey/streetsign

I entered the container and created a folder called database, copied database.db into it, edited config.py to have DATABASE_FILE='database/database.py' in it. [git not supporting adding empty directories is a real pain here, as we could patch config_default.py to have database file pointing the right way at an empty dir. Oh well.]

[daniel-lang]

You need more than that for production. config.py includes the salt of the passwords. So just the database will be useless after a rebuild.