search

danthorpe / Money

Swift value types for working with money & currency
MIT License
933 stars 91 forks source link

Update dependency Result to non-beta version #30

Closed mrdavey closed 8 years ago

mrdavey commented 8 years ago

In this file: https://github.com/danthorpe/Money/blob/development/Money.podspec, it shows a dependency:

s.dependency 'Result', '0.6.0-beta.6'

The beta version number causes a CFBundleVersion error when uploading to iTunes, as per this Stackoverflow thread: http://stackoverflow.com/a/33375436/4769084

My interim solution was to manually update the info.plist file of the pod, however using a non-beta dependency would probably be better.

danthorpe commented 8 years ago

Sorry about that @mrdavey - hadn't noticed that Result was finally out of beta - will fix it very now.

hsoi commented 8 years ago

How funny. I just ran into this exact same problem myself and was coming here to file an issue on it. :smile_cat:

Thank you for the speedy turnaround, @danthorpe

danthorpe commented 8 years ago

@hsoi - yeah, just sorting out a bitcode / watchOS / Carthage / Xcode 7.2 situation.... should be sorted very soon.

mrdavey commented 8 years ago

Thank you @danthorpe !

hsoi commented 8 years ago

No worries @danthorpe ! I'm taking @mrdavey 's same approach and just hacking the Info.plist of Result so I can build and submit (gotta get it submitted this morning).

But to have this properly sorted out will be good for post-release :+1:

Thanx again!

codecov-io commented 8 years ago

Current coverage is 0.00%

Merging #30 into development will decrease coverage by -100.00% as of 85ffb73

No diff could be generated. No reports for #30 found. Review entire Coverage Diff as of 85ffb73

Powered by Codecov. Updated on successful CI builds.

danthorpe commented 8 years ago

@mrdavey @hsoi - okay, sounds good - being practical. I knew that -beta6 was going to be a problem eventually... Also great that you're submitting apps with Money! (I've not actually got round to it myself yet!) :+1:

danthorpe commented 8 years ago

Pushed 1.4.2 to CocoaPods 😀

hsoi commented 8 years ago

@danthorpe thank you! Got it updated and things seem good.

Yup. Just submitted an app using Money ScoreSense Scores To Go, the 2.0 version will be using it. Helped me with some parsing and display stuff. :+1:

Thanx for it!