search

danurbanowicz / eleventy-netlify-boilerplate

A template for building a blog with the Eleventy static site generator and Decap CMS
https://eleventy-netlify-boilerplate.netlify.app/
MIT License
531 stars 183 forks source link

Title for Tag pages and sitemap.xml #15

Closed spekulatius closed 5 years ago

spekulatius commented 5 years ago

Hello @danurbanowicz

to save you some work I've added the titles to the tag pages as you described. I've also added a sitemap.xml in. Let me know if you don't want it and I'll remove it.

Cheers, Peter

danurbanowicz commented 5 years ago

Thanks for this @spekulatius

I would prefer not to include the sitemap in the project as it makes some assumptions which I don't feel should be made by us e.g. which pages to include in the sitemap. I don't feel comfortable with users having a sitemap that they didn't ask for sitting in their project root, and perhaps don't even know is there.

(also in the deploy preview the sitemap.njk is not outputting all of the tag pages into the xml file, not sure why)

spekulatius commented 5 years ago

Hello @danurbanowicz

I totally understand if you aren't keen on bringing in assumptions - I've removed the sitemap and updated the PR.

Not sure why not all tags where included - I've checked and found the same on my site. Thanks for point it out. I'll have a look 👍️

Peter

danurbanowicz commented 5 years ago

Thanks again for this @spekulatius !

spekulatius commented 5 years ago

No Problem!