search

danvallejo / andors-trail

Automatically exported from code.google.com/p/andors-trail
0 stars 0 forks source link

Combat bar's background extends too much after a battle #20

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Get into a few fights with animals
2. From time to time, rather rarely you'll get the effect that's visible on the 
attached image 

What is the expected output? What do you see instead?
Too much gray bg.

What version of the product are you using? On what operating system?
2.1 Update1; latest version of game up to date today, now.

Please provide any additional information below.

Can't wait for the map to be larger, keep on working on this, really like it 
and it's great fun!

Original issue reported on code.google.com by ksawer...@gmail.com on 20 Nov 2010 at 10:08

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks for the report. 

I've managed to recreate it. It's even easier to recreate in the emulator, so 
shame on me, I should have seen that while developing :)

Anyway, this seems to be a matter of two things:
 - No monster is selected in combat (so no monster button or hp bar to show)
 - The combat bar is visible without any actual monsters around.
The first is probably a consequence of the second, so I'll focus on that - why 
the combat bar can be visible when there are no monsters around.

On a side note, it's possible to remove the combat bar by either clicking the 
screen, or one of the "end .." buttons, right?

The circumstances where the combat bar could be visible without the player 
actually being in combat is a timing issue I think. When engaging combat, a new 
Android Activity is created, to display the "do you want to attack ..."-dialog. 
There is an inherent delay in opening Activities (it's done asynchronously to 
the program), so some things can happen while the Activity is being started. If 
you manage to click and kill the monster before that Activity has opened (and 
possibly even the "pick up items"-dialog), you will get into a state where the 
game thinks you are in combat, but the monster has already died. 

What I think we should do is place more safeguards around when it's allowed to 
click-to-attack and not. So that you cannot kill the monster before you have 
resolved the "do you want to attack.."-dialog. Hopefully that should solve this 
issue. I'll prioritise this for the next update.

Thanks again for reporting it! Please report more issues that you find.

Original comment by oskar.wi...@gmail.com on 22 Nov 2010 at 8:50

GoogleCodeExporter commented 8 years ago

Original comment by oskar.wi...@gmail.com on 22 Nov 2010 at 8:51

GoogleCodeExporter commented 8 years ago 
This one is fixed.

Original comment by SamuelPl...@gmail.com on 26 Nov 2010 at 10:26

GoogleCodeExporter commented 8 years ago 
This is now implemented. Closing this issue. Thanks again for all the good 
suggestions!

Original comment by oskar.wi...@gmail.com on 29 Nov 2010 at 9:40