search

danvergara / dblab

The database client every command line junkie deserves.
MIT License
2.4k stars 63 forks source link

Linux installation script not working right #208

Closed levkk closed 5 months ago

levkk commented 5 months ago

Describe the bug The Linux installation script installs the binary into ~/.local/bin, i.e. it makes that path the executable, not a folder, and doesn't copy the executable into it.

To Reproduce Steps to reproduce the behavior: Use the installation script with no arguments.

Expected behavior Should probably install it into ~/.local/bin/dblab although I don't think that's typically included into PATH. Might prompt for password and install into /usr/local/bin/dblab instead.

OS (please complete the following information):

danvergara commented 5 months ago

I can't reproduce the problem. I've been running this script on Mac, Fedora, Debian and Ubuntu for years and I had no problem at all.

I realized that the original script I took inspiration from was improved over the years, tho. I hope it addresses the installation issue.

I won't change the default value because current path is OK as it is and can changed by the user anytime, and won't change it to an administrator directory, either.