danvergara / dblab

The database client every command line junkie deserves.
MIT License
2.4k stars 63 forks source link

Mishandled expected error #229

Closed danvergara closed 3 months ago

danvergara commented 4 months ago

Mishandled expected error

Description

A user recently reported that he didn't like the way dblab handles error happening at getting the metadata of a table. The way it works right now is that dblab crashes and prints out the error. The expected behavior is that every error generated by queries are printed on the rows view. So, I went ahead and made sure those errors are printed on the view mentioned above.

Fixes #227

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Unfortunately, the gui package doesn't have a test suite. To test this out, I hard-coded a non-existent table. This is supposed to error out due to the table is no present in the database.

Screenshot from 2024-07-17 21-55-00

Now, the expected error shows up on the rows table.

Screenshot from 2024-07-17 21-09-18

Checklist: