The reasoning behind this changes is that, since we're working with files, we should be working with the abstraction of that, rather than working inner representation of the file. The benefit is that if the file is too large, we could split it into multiple chunks and process a stream of data.
Type of change
Please delete options that are not relevant.
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
How Has This Been Tested?
Tested it locally running the tests and I QA'd this with different kind of files.
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have checked my code and corrected any misspellings
Big Refactor on
ConvertosignatureDescription
This PR changes the signature of one of the methods of the
Fileinterface. From:To:
The reasoning behind this changes is that, since we're working with files, we should be working with the abstraction of that, rather than working inner representation of the file. The benefit is that if the file is too large, we could split it into multiple chunks and process a stream of data.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested it locally running the tests and I QA'd this with different kind of files.
Checklist: