search

danvk / oldnyc

Mapping photos of Old New York
Apache License 2.0
288 stars 130 forks source link

Re-style item view #42

Closed danvk closed 9 years ago

danvk commented 9 years ago

It currently looks cobbled together, especially on larger screens.

screen shot 2015-03-31 at 2 08 37 pm

danvk commented 9 years ago

@mgiraldo any ideas around this?

The bits of information currently there are:

mgiraldo commented 9 years ago

I do but implementing them required messing around a lot with the JavaScript and I didn't want to damage anything. I could do a PNG mockup if that works?

On Apr 29, 2015, at 10:10, Dan Vanderkam notifications@github.com wrote:

@mgiraldo any ideas around this?

The bits of information currently there are:

Image title ("Manhattan: 42nd Street (West) - 5th Avenue") Rotate 90° Feedback OCR'd text (where available) Link to the back of the image (where available) Link to this photo Tweet Like Facebook Share Facebook Comment — Reply to this email directly or view it on GitHub.

danvk commented 9 years ago

That would be great!

mgiraldo commented 9 years ago

does this help? it is mostly spacing stuff and text hierarchy

oldnyc-detail

rotate

the clipboard icon comes from octicons the text block width could also be % based but have a min-width of ~300px

danvk commented 9 years ago

Thanks, it does!

I'm a bit hesitant to put the rotate button on top of the photo like that. Most of the time it will be in the way & a distraction. It's just that for a smallish number (~10%) of photos, it's really helpful to have.

mgiraldo commented 9 years ago

rotate

danvk commented 9 years ago

Maybe the best solution is to show it on the bottom right. Then it will use any extra space available on either the bottom or the right, depending on the size of the image and the viewport.

Wide image: screen shot 2015-04-29 at 4 49 59 pm

Tall image: screen shot 2015-04-29 at 4 49 45 pm

mgiraldo commented 9 years ago

top right better?

this way it is immediately accesible not requiring a scroll

----- Original Message ----- From: "danvk/oldnyc" To:"danvk/oldnyc" Cc:"Mauricio Giraldo" Sent:Wed, 29 Apr 2015 13:54:06 -0700 Subject:Re: [oldnyc] Re-style item view (#42)

Maybe the best solution is to show it on the bottom right. Then it

will use any extra space available on either the bottom or the right, depending on the size of the image and the viewport. 

Wide image:

[1] 

Tall image:

[2] 

—

Reply to this email directly or view it on GitHub [3].

Links:

[1] https://cloud.githubusercontent.com/assets/98301/7401205/46aa8f74-ee90-11e4-8bd5-69fdf16c6ae4.png [2] https://cloud.githubusercontent.com/assets/98301/7401206/46aae992-ee90-11e4-804f-7602b3d9b22e.png [3] https://github.com/danvk/oldnyc/issues/42#issuecomment-97582949