search

danvk / oldnyc

Mapping photos of Old New York
Apache License 2.0
288 stars 130 forks source link

Style tweaks #52

Closed danvk closed 9 years ago

danvk commented 9 years ago

Fixes #37

I'm not quite sure what to do with the social links—the red background is a bit jarring, and they're more functional if they're on the left side of the page.

cc @mgiraldo

mgiraldo commented 9 years ago

try #898989 instead of red

----- Original Message ----- From: "danvk/oldnyc" To:"danvk/oldnyc" Cc:"Mauricio Giraldo" Sent:Wed, 29 Apr 2015 09:07:28 -0700 Subject:Re: [oldnyc] Style tweaks (#52)

Merged #52 [1]. 

—

Reply to this email directly or view it on GitHub [2].

Links:

[1] https://github.com/danvk/oldnyc/pull/52 [2] https://github.com/danvk/oldnyc/pull/52#event-293158530

danvk commented 9 years ago

I'm not sure why it needs to be so dark. What do you think of #E0C3C3?

screen shot 2015-04-29 at 3 20 20 pm

danvk commented 9 years ago

#eee (same as the popular photos panel) also looks reasonable:

screen shot 2015-04-29 at 3 21 49 pm

mgiraldo commented 9 years ago

👍

----- Original Message ----- From: "danvk/oldnyc" To:"danvk/oldnyc" Cc:"Mauricio Giraldo" Sent:Wed, 29 Apr 2015 12:22:32 -0700 Subject:Re: [oldnyc] Style tweaks (#52)

#eee (same as the popular photos panel) also looks reasonable: 

 [1] 

—

Reply to this email directly or view it on GitHub [2].

Links:

[1] https://cloud.githubusercontent.com/assets/98301/7399376/83213e06-ee83-11e4-9ed7-c39665027cb3.png [2] https://github.com/danvk/oldnyc/pull/52#issuecomment-97550007

danvk commented 9 years ago

:+1: to the gray or light red? :)

mgiraldo commented 9 years ago

oh... didnt see the red one... i think gray...